Custom registry by MeAlam1 · Pull Request #163 · MeAlam1/BlueLib

MeAlam1 · 2025-08-06T18:53:46Z

No description provided.

Added keybind registries

… custom-registry # Conflicts: # common/build.gradle # fabric/src/main/java/software/bluelib/BlueLib.java # neoforge/build.gradle # neoforge/src/main/java/software/bluelib/BlueLib.java # neoforge/src/main/java/software/bluelib/client/BlueLibClient.java

… custom-registry # Conflicts: # common/src/main/java/software/bluelib/BlueLibCommon.java # common/src/main/java/software/bluelib/internal/registry/TestEntityReg.java # common/src/main/java/software/bluelib/platform/IRegistryHelper.java # common/src/main/resources/META-INF/accesstransformer-nf.cfg # fabric/src/main/java/software/bluelib/BlueLib.java # fabric/src/main/java/software/bluelib/platform/FabricRegistryHelper.java # fabric/src/main/resources/bluelib.accesswidener # fabric/src/main/resources/fabric.mod.json # neoforge/src/main/java/software/bluelib/BlueLib.java # neoforge/src/main/java/software/bluelib/platform/NeoForgeRegistryHelper.java

Fixed blockstate gen returning null Fixed recipe gen only generating one item recipe

…istry # Conflicts: # common/src/main/java/software/bluelib/internal/registry/TestEntityReg.java

… custom-registry # Conflicts: # common/src/main/java/software/bluelib/BlueLibCommon.java # common/src/main/java/software/bluelib/BlueLibConstants.java # common/src/main/java/software/bluelib/api/entity/variant/IVariantEntity.java # common/src/main/java/software/bluelib/api/event/mod/ModIntegration.java # common/src/main/java/software/bluelib/api/json/JSONMerger.java # common/src/main/java/software/bluelib/api/json/JSONParser.java # common/src/main/java/software/bluelib/api/net/NetworkPacket.java # common/src/main/java/software/bluelib/api/utils/IsValidUtils.java # common/src/main/java/software/bluelib/api/utils/conversion/CaseConverterUtils.java # common/src/main/java/software/bluelib/api/utils/conversion/ColorConverterUtils.java # common/src/main/java/software/bluelib/api/utils/conversion/MathConverterUtils.java # common/src/main/java/software/bluelib/api/utils/math/AlgebraicUtils.java # common/src/main/java/software/bluelib/api/utils/math/GeometricUtils.java # common/src/main/java/software/bluelib/api/utils/math/MatrixUtils.java # common/src/main/java/software/bluelib/api/utils/math/RandomGenUtils.java # common/src/main/java/software/bluelib/api/utils/math/StatisticalUtils.java # common/src/main/java/software/bluelib/api/utils/minecraft/ChunkUtils.java # common/src/main/java/software/bluelib/api/utils/variant/ParameterUtils.java # common/src/main/java/software/bluelib/client/gui/logging/LoggerScreen.java # common/src/main/java/software/bluelib/commands/OpenLoggerScreenCommand.java # common/src/main/java/software/bluelib/compat/jei/BlueJeiPlugin.java # common/src/main/java/software/bluelib/entity/variant/VariantLoader.java # common/src/main/java/software/bluelib/event/ReloadHandler.java # common/src/main/java/software/bluelib/markdown/MarkdownFeature.java # common/src/main/java/software/bluelib/markdown/MarkdownParser.java # common/src/main/java/software/bluelib/markdown/syntax/Color.java # common/src/main/java/software/bluelib/markdown/syntax/CopyToClipboard.java # common/src/main/java/software/bluelib/markdown/syntax/Hyperlink.java # common/src/main/java/software/bluelib/mixin/common/brewing/BrewingStandBlockEntityMixin.java # common/src/main/java/software/bluelib/net/messages/client/OpenLoggerPacket.java # common/src/main/java/software/bluelib/net/messages/client/variant/AllDataPacket.java # common/src/main/java/software/bluelib/net/messages/client/variant/ParameterDataPacket.java # common/src/main/java/software/bluelib/net/messages/client/variant/VariantsPacket.java # common/src/main/java/software/bluelib/net/messages/server/TestPacket.java # common/src/main/java/software/bluelib/net/serverHandling/TestPacketHandler.java # common/src/main/java/software/bluelib/platform/IPlatformHelper.java # common/src/main/java/software/bluelib/platform/IRegistryHelper.java # fabric/src/main/java/software/bluelib/BlueLib.java # fabric/src/main/java/software/bluelib/config/BlueLibConfig.java # fabric/src/main/java/software/bluelib/platform/FabricPlatformHelper.java # fabric/src/main/java/software/bluelib/platform/FabricRegistryHelper.java # gradle/libs.versions.toml # neoforge/src/main/java/software/bluelib/BlueLib.java # neoforge/src/main/java/software/bluelib/client/BlueLibClient.java # neoforge/src/main/java/software/bluelib/config/BlueLibConfig.java # neoforge/src/main/java/software/bluelib/event/ReloadHandler.java # neoforge/src/main/java/software/bluelib/platform/NeoForgePlatformHelper.java # neoforge/src/main/java/software/bluelib/platform/NeoForgeRegistryHelper.java

Copilot

Pull Request Overview

This PR introduces a comprehensive custom registry system for the BlueLib mod framework, providing unified registration across platforms (Fabric and NeoForge) with automatic data generation capabilities.

Implements builder pattern for registering items, blocks, entities, and other game objects
Adds automatic generation of data files (recipes, models, blockstates) during development
Unifies registration logic across Fabric and NeoForge platforms

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
NeoForgeRegistryHelper.java	Implements NeoForge-specific registration methods for items, blocks, entities, etc.
FabricRegistryHelper.java	Implements Fabric-specific registration methods using built-in registries
AbstractRegistryBuilder.java	Core registry builder providing platform-agnostic registration API
Various builder classes	Builder pattern implementations for different game object types
Data generation classes	Automatic generation of JSON files for recipes, models, and blockstates

Copilot · 2025-08-06T18:55:17Z

neoforge/src/main/java/software/bluelib/platform/NeoForgeRegistryHelper.java

 package software.bluelib.platform;

 import java.util.function.Supplier;
+import java.util.function.Supplier;


There is a duplicate import of java.util.function.Supplier on lines 10 and 11. Remove the duplicate import.

Suggested change

import java.util.function.Supplier;

Copilot · 2025-08-06T18:55:17Z

fabric/src/main/java/software/bluelib/platform/FabricRegistryHelper.java

 package software.bluelib.platform;

 import java.util.function.Supplier;
+import java.util.function.Supplier;


There is a duplicate import of java.util.function.Supplier on lines 10 and 11. Remove the duplicate import.

Suggested change

import java.util.function.Supplier;

Copilot · 2025-08-06T18:55:18Z

fabric/src/main/java/software/bluelib/platform/FabricRegistryHelper.java

+import net.minecraft.world.level.block.Block;
+import net.minecraft.world.level.block.entity.BlockEntity;
+import net.minecraft.world.level.block.entity.BlockEntityType;
 import net.minecraft.core.Holder;


There are duplicate imports for several Minecraft classes (Holder, Registry, BuiltInRegistries) between lines 15-18 and 28-31. Remove the duplicate imports.

Copilot · 2025-08-06T18:55:18Z

common/src/main/java/software/bluelib/api/registry/datagen/recipe/RecipeUtils.java

+		try {
+			Field resultField = recipe.getClass().getDeclaredField("result");
+			resultField.setAccessible(true);
+			Object value = resultField.get(recipe);
+			if (value instanceof ItemStack stack) {
+				return stack;
+			}
+		} catch (Exception ignored) {}


This method uses reflection to access private fields, which is fragile and could break with code changes. Consider using a more stable approach or adding proper error handling for when the field doesn't exist.

Suggested change

try {

Field resultField = recipe.getClass().getDeclaredField("result");

resultField.setAccessible(true);

Object value = resultField.get(recipe);

if (value instanceof ItemStack stack) {

return stack;

}

} catch (Exception ignored) {}

// Try to access the "result" field, with proper error handling and alternative field names

String[] possibleFieldNames = {"result", "f_43781_"}; // Add obfuscated or alternative names if needed

for (String fieldName : possibleFieldNames) {

try {

Field resultField = recipe.getClass().getDeclaredField(fieldName);

resultField.setAccessible(true);

Object value = resultField.get(recipe);

if (value instanceof ItemStack stack) {

return stack;

}

} catch (NoSuchFieldException e) {

// Field not found, try next

} catch (IllegalAccessException e) {

System.err.println("Failed to access field '" + fieldName + "' in " + recipe.getClass().getName() + ": " + e.getMessage());

} catch (Exception e) {

System.err.println("Unexpected error accessing field '" + fieldName + "' in " + recipe.getClass().getName() + ": " + e.getMessage());

}

}

System.err.println("Could not retrieve 'result' field from recipe class: " + recipe.getClass().getName());

Dan6335 and others added 28 commits May 13, 2025 15:56

Begun work on custom registry builder

46c6f8a

Solved the hardcoded modid issue

d168555

Tweaked the modid getter

5fc148b

Made some tweaks

127f6cf

Fixed the comment

b911710

Optimized imports

7d7d50b

Tweaked this

cdc6410

Made all builders get modId from RegistryBuilder.getModID

1ca3676

Added block entity registries

c94158d

Added keybind registries

Fixed the accesstransformer-nf.cfg and bluelib.accesswidener

abbfca6

Forgot this

2b9f15f

Moved neoforge entity renderer to neo registry helper

da0e9b8

My latest menu registry work

2049ea7

Fixed fabric creative tab error

df0f70d

Started work on recipe gen and fixed errors found in ToV

78f9b1a

Fixed recipe gen

a5cba1b

Fixed recipe gen not generating correct recipes

206bce7

Fixed blockstate gen returning null Fixed recipe gen only generating one item recipe

Added the smithing recipes

26fae97

Added fabric recipe gen and removing smithing trip for now

e846338

Fixed LivingEntity Builder

26b7dbb

Added the ability to create ores using .ore()

f91fcc0

Merge remote-tracking branch 'origin/custom-registry' into custom-reg…

4afbd8e

…istry # Conflicts: # common/src/main/java/software/bluelib/internal/registry/TestEntityReg.java

Added the ability to create wood blocks using .wood()

7f0c7eb

Fixed registry error

c1f8718

Spotless

d6947aa

MeAlam1 added this to the 3.0.0 milestone Aug 6, 2025

MeAlam1 self-assigned this Aug 6, 2025

MeAlam1 added this to BlueLib Features Aug 6, 2025

Copilot AI review requested due to automatic review settings August 6, 2025 18:53

MeAlam1 added Enhancement New feature or request 1.21 Minecraft Version labels Aug 6, 2025

MeAlam1 moved this to In Progress in BlueLib Features Aug 6, 2025

Removed duplicate accesstransformer.cfg

5977f70

Copilot AI reviewed Aug 6, 2025

View reviewed changes

MeAlam1 marked this pull request as draft August 6, 2025 19:20

Repository owner deleted a comment from Copilot AI Aug 7, 2025

MeAlam1 and others added 2 commits August 7, 2025 13:53

Started working on Nuking Statics, Dan will finish it

ab5079b

Removed static methods from all registry builders

d065865

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Custom registry#163

Custom registry#163
MeAlam1 wants to merge 31 commits into1.21-1.21.3from
custom-registry

MeAlam1 commented Aug 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-		try {
-			Field resultField = recipe.getClass().getDeclaredField("result");
-			resultField.setAccessible(true);
-			Object value = resultField.get(recipe);
-			if (value instanceof ItemStack stack) {
-				return stack;
-			}
-		} catch (Exception ignored) {}
+		// Try to access the "result" field, with proper error handling and alternative field names
+		String[] possibleFieldNames = {"result", "f_43781_"}; // Add obfuscated or alternative names if needed
+		for (String fieldName : possibleFieldNames) {
+			try {
+				Field resultField = recipe.getClass().getDeclaredField(fieldName);
+				resultField.setAccessible(true);
+				Object value = resultField.get(recipe);
+				if (value instanceof ItemStack stack) {
+					return stack;
+				}
+			} catch (NoSuchFieldException e) {
+				// Field not found, try next
+			} catch (IllegalAccessException e) {
+				System.err.println("Failed to access field '" + fieldName + "' in " + recipe.getClass().getName() + ": " + e.getMessage());
+			} catch (Exception e) {
+				System.err.println("Unexpected error accessing field '" + fieldName + "' in " + recipe.getClass().getName() + ": " + e.getMessage());
+			}
+		}
+		System.err.println("Could not retrieve 'result' field from recipe class: " + recipe.getClass().getName());

Comments

Conversation

MeAlam1 commented Aug 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants